Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyout: keeps the page when switching version/language #242

Merged
merged 10 commits into from
Mar 5, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 8, 2024

Closes #211
Closes #131
Closes #130

@humitos humitos requested a review from a team as a code owner February 8, 2024 09:20
@humitos humitos requested a review from agjohnson February 8, 2024 09:20
src/flyout.js Outdated Show resolved Hide resolved
src/flyout.js Show resolved Hide resolved
src/flyout.js Outdated Show resolved Hide resolved
@humitos
Copy link
Member Author

humitos commented Feb 21, 2024

I think this PR is ready to merge. Just waiting on the backend PR that is required.

@humitos humitos added the Status: blocked Issue is blocked on another issue label Feb 27, 2024
@humitos
Copy link
Member Author

humitos commented Feb 27, 2024

I'm blocking this PR because we need to fix the construction of new URL first. See #242 (comment)

@humitos humitos removed the Status: blocked Issue is blocked on another issue label Mar 4, 2024
src/flyout.js Outdated Show resolved Hide resolved
@humitos humitos merged commit d1ba63c into main Mar 5, 2024
4 checks passed
@humitos humitos deleted the humitos/flyout-urls branch March 5, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants